Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFI: Expose ed25519/curve25519 keys in bindings #3420

Merged
merged 3 commits into from
May 17, 2024

Conversation

BillCarsonFr
Copy link
Member

The Element-X rageshakes are lacking device keys info, see element-hq/element-x-ios#2550

This change exposes these so that it can be used by the app.
The ed25519_key() was already present in the sdk but not exposed in bindings. I added a second one for curve25519_key() in both sdk and bindings.

Can be accessed via client.encryption().curve25519Key() in the aps

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner May 16, 2024 08:29
@BillCarsonFr BillCarsonFr requested review from Hywan and removed request for a team May 16, 2024 08:29
bnjbvr
bnjbvr previously requested changes May 16, 2024
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the contribution guidelines when it comes to PR names.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.97%. Comparing base (cbb92ca) to head (f5cddec).
Report is 20 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk/src/encryption/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3420      +/-   ##
==========================================
- Coverage   82.98%   82.97%   -0.02%     
==========================================
  Files         246      246              
  Lines       25011    25012       +1     
==========================================
- Hits        20756    20754       -2     
- Misses       4255     4258       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr BillCarsonFr changed the title Expose ed25519/curve25519 keys in bindings FFI: Expose ed25519/curve25519 keys in bindings May 16, 2024
@BillCarsonFr BillCarsonFr force-pushed the valere/expose_device_keys_in_bindings_for_rs branch from 796c240 to 6ec61d5 Compare May 16, 2024 08:43
@BillCarsonFr BillCarsonFr requested a review from bnjbvr May 16, 2024 09:32
@bnjbvr bnjbvr removed their request for review May 16, 2024 09:36
@bnjbvr bnjbvr dismissed their stale review May 16, 2024 09:36

thanks for updating the title!

@poljar
Copy link
Contributor

poljar commented May 17, 2024

Could you make CI happy? I think that this is should be a pretty trivial change, but CI failures need to be addressed.

@BillCarsonFr
Copy link
Member Author

Could you make CI happy? I think that this is should be a pretty trivial change, but CI failures need to be addressed.

Oh sry, I missed the failing checks

@poljar poljar merged commit 6111bed into main May 17, 2024
35 checks passed
@poljar poljar deleted the valere/expose_device_keys_in_bindings_for_rs branch May 17, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants