-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFI: Expose ed25519/curve25519 keys in bindings #3420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the contribution guidelines when it comes to PR names.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
==========================================
- Coverage 82.98% 82.97% -0.02%
==========================================
Files 246 246
Lines 25011 25012 +1
==========================================
- Hits 20756 20754 -2
- Misses 4255 4258 +3 ☔ View full report in Codecov by Sentry. |
796c240
to
6ec61d5
Compare
Could you make CI happy? I think that this is should be a pretty trivial change, but CI failures need to be addressed. |
Oh sry, I missed the failing checks |
The Element-X rageshakes are lacking device keys info, see element-hq/element-x-ios#2550
This change exposes these so that it can be used by the app.
The
ed25519_key()
was already present in the sdk but not exposed in bindings. I added a second one forcurve25519_key()
in both sdk and bindings.Can be accessed via
client.encryption().curve25519Key()
in the apsSigned-off-by: