-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update widget tile if the url should change #12381
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was specifically not done as it'd kick you out of conferences/forms etc if the widget takes a param which changes, e.g. theme combined with #12295
Okay, then I think we probably need a way to raise the non-ready state so the tile isn't presented as ready until we have our URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wants a test for the scalar token & the theme variable cases
Moving to draft while this remains in progress |
Fixes element-hq/element-integration-manager#116
The scalar token can arrive async after we've rendered a widget, which means we may need to change the URL of the app tile after this has happened. It felt reasonable to me to raise an event from the widget to the tile when this happens.
Checklist
public
/exported
symbols have accurate TSDoc documentation.