Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update widget tile if the url should change #12381

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Mar 27, 2024

Fixes element-hq/element-integration-manager#116

The scalar token can arrive async after we've rendered a widget, which means we may need to change the URL of the app tile after this has happened. It felt reasonable to me to raise an event from the widget to the tile when this happens.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@Half-Shot Half-Shot requested a review from a team as a code owner March 27, 2024 18:02
@Half-Shot Half-Shot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Mar 27, 2024
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was specifically not done as it'd kick you out of conferences/forms etc if the widget takes a param which changes, e.g. theme combined with #12295

@Half-Shot
Copy link
Contributor Author

Okay, then I think we probably need a way to raise the non-ready state so the tile isn't presented as ready until we have our URL.

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wants a test for the scalar token & the theme variable cases

@richvdh
Copy link
Member

richvdh commented Apr 3, 2024

Moving to draft while this remains in progress

@richvdh richvdh removed their request for review April 3, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrations "API Error (403): Missing access token" on develop and nightly
3 participants