Fix GitLab's ready for review hook #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far back as I could go in the docs (GitLab 14.10), the keys for changes have been `previous` and `current`. There is a `draft` change that we can use directly instead of guessing from the title. The type of the value depends on the key of the change. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Half-Shot
requested changes
May 22, 2024
|
Woops, I had forgotten to push the commit 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code resulted on this error when there was a title change (rest of the stack trace omitted):
As far back as I could go in the docs (GitLab 14.10), the keys for changes have been
previousandcurrent. Besides, there is adraftchange that we can use directly instead of guessing from the title.I removed the
[key: string]type declaration because the type of the value depends on the key of the change.