Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for crypto store PVC to helm chart #920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PseudoResonance
Copy link

Adds a persistence section to the Helm chart so that the encryption crypto store can persist through restarts/updates.

Signed-off-by: PseudoResonance <kaio11604@gmail.com>
@PseudoResonance PseudoResonance requested a review from a team as a code owner April 3, 2024 10:54
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but one question.

@@ -92,6 +92,15 @@ resources: {}
# cpu: 100m
# memory: 128Mi

# Persistent volume for encryption store, mounted in the pod as /persistent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to configure hookshot to use this?

@PseudoResonance
Copy link
Author

Yes, the following needs to be added to the Helm values under hookshot.config.

    experimentalEncryption:
      storagePath: /persistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants