Add a type label to metric hookshot_connections
#682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Mar 24, 2023
Comment on lines
+65
to
+66
| const cd: ConnectionDeclaration = Object.getPrototypeOf(connection).constructor; | ||
| const canonicalEvent = cd?.EventTypes?.[0] ?? 'unknown'; |
There was a problem hiding this comment.
Object.getPrototypeOf(connection).constructor
Just because JavaScript allows you to do this, doesn't mean you should.
If there's no other simple way to accomplish this, please add an inline comment of what this is doing.
The following things are uncommon about this (aka. I've never seen them used in a JavaScript project):
- getting the prototype of an object
- assigning the constructor of a class to a new variable
- not executing a constructor, but instead using it like an object variable to get data from the class
There was a problem hiding this comment.
This does feel like a bit of ETOOMUCHMAGIC. A lot of fancy footwork to basically dodge the interface boundary and pull EventTypes out of the class itself. Feels like if we need to do this then EventTypes (or CanonicalEventType) should just be a public property of IConnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.