Refactor Jira OnPrem OAuth to add unit tests #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2023 23:34
jaller94
commented
Jan 12, 2023
| return parameter.startsWith("oauth_"); | ||
| } | ||
|
|
||
| export const makeArrayOfArgumentsHash = (argumentsHash: Map<string, string | string[]>): [string, string][] => { |
There was a problem hiding this comment.
Not sure why this is Map<string, string | string[]> instead of Map<string, string>.
Issue #621
This was an issue before and I didn't remove the support for string[].
Please let's not make that a blocker for this PR.
jaller94
commented
Jan 12, 2023
Comment on lines
+215
to
+219
| mockServerResponse = { | ||
| oauth_token: "abc", | ||
| oauth_token_secret: "def", | ||
| }; | ||
| const actual = await jiraOAuth.exchangeRequestForToken("foo", "bar"); |
There was a problem hiding this comment.
If mocha runs the tests in parallel, this is a race condition with the other tests.
jaller94
commented
Jan 12, 2023
| redirect_uri: "https://redirect", | ||
| }; | ||
| // This private key is ONLY used for testing. It's safe to be published. | ||
| const privateKey = `-----BEGIN PRIVATE KEY----- |
There was a problem hiding this comment.
GitHub key scanner report coming in 10... 9... 8... 7...
As mentioned in the comment, I generated this key just for testing.
jaller94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnPremOAuth.ts.OnPremOAuth.tsto be simpler, safer and more testable.Tip for reviewing: Pretend that this is new code – comparing it to the old code has become increasingly difficult. Test it with a Jira instance.