Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI build. #11052

Merged
merged 1 commit into from Apr 15, 2018
Merged

Fix CircleCI build. #11052

merged 1 commit into from Apr 15, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 15, 2018

Looks like release of pip 10 broke the circleci build. See e.g. https://circleci.com/gh/anntzer/matplotlib/2659?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link, pypa/pip#5221.

Using python -mpip instead of pip is generally a good thing (tm),
and also what we already do for travis.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Looks like release of pip 10 broke the circleci build.

Using `python -mpip` instead of `pip` is generally a good thing (tm),
and also what we already do for travis.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. Build labels Apr 15, 2018
@anntzer
Copy link
Contributor Author

anntzer commented Apr 15, 2018

(the appveyor build is actually passing: https://ci.appveyor.com/project/matplotlib/matplotlib)

@tacaswell tacaswell modified the milestones: v3.0, v2.2.3 Apr 15, 2018
@tacaswell tacaswell merged commit c98be63 into matplotlib:master Apr 15, 2018
lumberbot-app bot pushed a commit that referenced this pull request Apr 15, 2018
@anntzer anntzer deleted the unbreak-circleci branch April 15, 2018 23:36
tacaswell added a commit that referenced this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants