Marketplace description language reworked #21773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comradekingu
commented
Jan 6, 2024
| "LicenseKeyExpiresSoon": "Your license key expires soon. Please contact %1$s.", | ||
| "LicenseKeyIsExpired": "Your license key has expired. Please contact %1$s.", | ||
| "MultiServerEnvironmentWarning": "Installing this plugin (or new version of it) must be done manually on each server you are using it on. Otherwise it would only change on one server.", | ||
| "AutoUpdateDisabledWarning": "Allow auto-installation of new versions by setting %1$s in %2$s to install or get a new version of this plugin directly.", |
There was a problem hiding this comment.
(Assuming here "directly" means ~"non-manually".)
comradekingu
commented
Jan 6, 2024
plugins/Marketplace/lang/en.json
Outdated
| "LicenseExceeded": "License exceeded", | ||
| "LicenseExceededDescription": "The licenses for the following plugins are no longer valid as the number of authorized users for the license is exceeded: %1$s. %2$sYou will not be able to download updates for these plugins. To resolve this issue either delete some users or %3$supgrade the subscription now%4$s.", | ||
| "PluginLicenseExceededDescription": "You are not allowed to download this plugin. The license for this plugin is no longer valid as the number of authorized users for the license is exceeded. To resolve this issue either delete some users or upgrade your subscription now.", | ||
| "LicenseExceededDescription": "%3$sUpgrade your license%4$s or remove users to keep using %1$s. %2$sThen you can also get new versions.", |
There was a problem hiding this comment.
I don't understand what the %2$s is doing here.
There was a problem hiding this comment.
Removing the whitespace then. :)
comradekingu
commented
Jan 6, 2024
comradekingu
commented
Jan 7, 2024
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale for long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
More understandable and translatable strings.
Part-way does away with describing "license" as "subscription" so as to only have one term in use.
Review