Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to distinguish between MySQL and MariaDB (also in installation) #18371

Merged
merged 22 commits into from
May 17, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 24, 2021

Description:

This is a small draft how to solve issues that might occur in MariaDb only.
I've only spent a couple of minutes to do the changes, so I'm not even sure if it would even fully work.

I currently don't have time to finish this PR or even test if everything works as expected.
If someone has some time, feel free to pick it up.

When finished this aims to fix #18360

This PR will change some test runs to use MariaDb instead of MySQL. This currently only affects PHP tests (Unit, Integration, System). Due to some fixtures using the same datetime for their visits, the UI tests would currently fail on MariaDb due to different sorting behaviour compared to MySQL.

Requires matomo-org/github-action-tests#16 and matomo-org/plugin-MarketingCampaignsReporting#152

Review

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 24, 2021
@sgiehl sgiehl added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Nov 24, 2021
@jorgeuos
Copy link

I'm curios though if there's other functionality that looks for SELECT in their queries. And if it would break backwards compatibility. Haven't had time to look into that yet.
Considering the comment from @tsteur here: #18360 (comment)
Mostly just core DB updates I would guess, but IDK right now.
Although don't think it's related to why the build failed: https://app.travis-ci.com/github/matomo-org/matomo/jobs/549521319#L1078
I would need to run the tests locally first.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 9, 2021
@sgiehl sgiehl added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Dec 9, 2021
@sgiehl sgiehl force-pushed the mariadb branch 2 times, most recently from 3f35bbe to 6146b55 Compare May 9, 2022 09:34
@sgiehl sgiehl mentioned this pull request Aug 22, 2022
@sgiehl sgiehl changed the base branch from 4.x-dev to 5.x-dev March 16, 2023 08:45
@sgiehl sgiehl force-pushed the mariadb branch 2 times, most recently from 406cd40 to 2ebafe7 Compare March 16, 2023 15:05
@sgiehl sgiehl force-pushed the mariadb branch 11 times, most recently from 42eb5f1 to 5f0f9f0 Compare May 7, 2024 10:07
@sgiehl sgiehl force-pushed the mariadb branch 2 times, most recently from e03225e to bd7646d Compare May 14, 2024 14:24
@sgiehl sgiehl added this to the 5.1.0 milestone May 14, 2024
@sgiehl sgiehl requested a review from a team May 14, 2024 18:57
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Do not close PRs with this label won't be marked as stale by the Close Stale Issues action labels May 14, 2024
sgiehl and others added 2 commits May 15, 2024 16:38
Co-authored-by: Marc Neudert <marc@innocraft.com>
@mneudert mneudert merged commit 2743e52 into 5.x-dev May 17, 2024
24 of 25 checks passed
@mneudert mneudert deleted the mariadb branch May 17, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration of max execution time when using MariaDB
4 participants