Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard strict mode #438

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hard strict mode #438

wants to merge 2 commits into from

Conversation

hannesa2
Copy link
Collaborator

No description provided.

@hannesa2 hannesa2 force-pushed the HardStrictMode branch 10 times, most recently from f1da2bb to 53e905d Compare September 25, 2023 06:15
@hannesa2
Copy link
Collaborator Author

hannesa2 commented Sep 25, 2023

Hmm, same strict mode finds a lot locally but not on CI

image

StrictMode policy violation; ~duration=5 ms: android.os.strictmode.DiskReadViolation
   at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1596)
   at libcore.io.BlockGuardOs.access(BlockGuardOs.java:71)
   at libcore.io.ForwardingOs.access(ForwardingOs.java:72)
   at android.app.ActivityThread$AndroidOs.access(ActivityThread.java:7533)
   at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:281)
   at java.io.File.exists(File.java:815)
   at android.app.ContextImpl.getDataDir(ContextImpl.java:2539)
   at android.app.ContextImpl.getPreferencesDir(ContextImpl.java:626)
   at android.app.ContextImpl.getSharedPreferencesPath(ContextImpl.java:853)
   at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:475)
   at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:188)
   at org.matomo.sdk.Matomo.<init>(Matomo.kt:36)
   at org.matomo.sdk.Matomo.<init>(Unknown Source:0)
   at org.matomo.sdk.Matomo$Companion.getInstance(Matomo.kt:74)
   at org.matomo.sdk.Matomo.getInstance(Unknown Source:5)
   at org.matomo.sdk.extra.MatomoApplication.getMatomo(MatomoApplication.java:20)
   at org.matomo.sdk.extra.MatomoApplication.getTracker(MatomoApplication.java:29)
   at org.matomo.demo.DemoApp.onInitTracker(DemoApp.kt:54)
   at org.matomo.demo.DemoApp.onCreate(DemoApp.kt:37)
   at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1192)
   at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6712)
   at android.app.ActivityThread.access$1300(ActivityThread.java:237)
   at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913)
   at android.os.Handler.dispatchMessage(Handler.java:106)

@hannesa2 hannesa2 force-pushed the HardStrictMode branch 3 times, most recently from 6e7c9e9 to 0e1e431 Compare September 25, 2023 08:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #438 (5cc4fe5) into master (013e18e) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##             master     #438   +/-   ##
=========================================
  Coverage     87.12%   87.12%           
  Complexity      364      364           
=========================================
  Files            32       32           
  Lines          1429     1429           
  Branches        165      165           
=========================================
  Hits           1245     1245           
  Misses          115      115           
  Partials         69       69           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hannesa2 hannesa2 force-pushed the HardStrictMode branch 5 times, most recently from e093b80 to 09c1e26 Compare September 26, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants