Correct setting of MarkerFaceColor / MarkerEdgeColor

[steefan85]

Fixes #1082

Changed '' to 'draw' for marker options, because in tikz
Matlabs MarkerFaceColor and MarkerEdgeColor are equivalent to fill and draw

but previous code set it to
mark options={fill=..., ...}

[miscco]

Thanks for your contribution

[miscco]

Hm I know that the repo is currently rather slow, but please do not conflate different features into one PR.

1. It makes reviewing much harder
2. If there is an error it takes much longer to progress
3. If there is a regression found later we need to revert the whole thing instead of the small part

[steefan85]

I just changed my forked repo for my own purposes. Didn't know it will automatically generate a new pull request here.

[miscco]

Yeah, Github tracks the branch you used to generate the pull request so that it is always up to date.

That is the reason why one should always create a feature branch rather than working o master/main directly

[ThexXTURBOXx]

This one has been partly resolved in f299888
However, this change has not yet been applied. Is it still needed?

[i3roly]

bump. this change is still needed, in particular the

 [m2t, markerInfo.options] = setColor(m2t, h, markerInfo.options, 'draw', color);

to

 [m2t, markerInfo.options] = setColor(m2t, h, markerInfo.options, '', color);

is required for the MarkerFaceColor to properly propagate to the tex file. otherwise it will just fill the marker with the line colour.

[ThexXTURBOXx]

@i3roly Then what I suggested seems to be correct, right?

[i3roly]

Whomever made that commit is correct, yes. I should note a portion of it seems to have been included, just not the part I've referenced in my earlier post. Sent from my BlackBerry 10 smartphone on the Rogers network. From: Nico MexisSent: Sunday, 18 February 2024 2:15 PMTo: matlab2tikz/matlab2tikzReply To: matlab2tikz/matlab2tikzCc: gagan sidhu; MentionSubject: Re: [matlab2tikz/matlab2tikz] Correct setting of MarkerFaceColor / MarkerEdgeColor (#1083) @i3roly Then what I suggested seems to be correct, right? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#1083 (comment)", "url": "#1083 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]