Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #1057 #1058

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Attempt to fix #1057 #1058

wants to merge 6 commits into from

Conversation

mengtongwqh
Copy link

@mengtongwqh mengtongwqh commented Jul 12, 2019

Prior to Octave 4.4.0, x_viewtransform of the axes object can be accessed by get function. This is not the case after Octave 4.4.0 and the code throws an error. This fix makes x_viewtransform available again by computing it following the Octave 4.2.2 source code.
Tested on Octave 5.1.0 and 4.2.2.

corrmaan and others added 6 commits February 11, 2019 09:19
Co-Authored-By: corrmaan <16811115+corrmaan@users.noreply.github.com>
Co-Authored-By: corrmaan <16811115+corrmaan@users.noreply.github.com>
Fix for GNU/Octave not including legends
@mengtongwqh mengtongwqh changed the base branch from master to develop July 12, 2019 15:01
@mengtongwqh mengtongwqh changed the title reconstruct x_viewtransform matrix for octave version >= 4.4.0 Attempt to fix #1057 Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants