Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the cache options to resolve expected behaviour #187

Merged
merged 8 commits into from Jan 14, 2024

Conversation

shaps80
Copy link
Collaborator

@shaps80 shaps80 commented Oct 31, 2023

AFAICT the cache policy is kind of a requirement or feature or the Combine approach. Whereas for an async call, this is not actually relevant or likely expected behaviour.

As such, I force it to not use any local caching.

Thanks for raising 👍

Additionally, this PR removes Yarn dependency in favour of PNPM and deletes the dead code files that we aren't and won't be using in the future.

@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swift-graphql ❌ Failed (Inspect) Jan 14, 2024 1:44pm

@maticzav
Copy link
Owner

maticzav commented Dec 6, 2023

@shaps80 could you elaborate what this does in more detail? Why is it necessary? Only writing a PR title is not enough.

@shaps80
Copy link
Collaborator Author

shaps80 commented Dec 6, 2023

@maticzav apologies you're right. I'll update the description but essentially AFAICT the cache policy is kind of a requirement or feature or the Combine approach. Whereas for an async call, this is not actually relevant or likely expected behaviour.

As such, I force it to not use any local caching.

Thanks for raising 👍

@yonaskolb
Copy link
Contributor

@shaps80 could you elaborate what this does in more detail? Why is it necessary? Only writing a PR title is not enough.

@maticzav there's a bit more context here #184 (comment)

@shaps80
Copy link
Collaborator Author

shaps80 commented Dec 11, 2023

@shaps80 could you elaborate what this does in more detail? Why is it necessary? Only writing a PR title is not enough.

@maticzav there's a bit more context here #184 (comment)

👍 thanks for this!

@maticzav maticzav merged commit ede32ca into main Jan 14, 2024
4 of 5 checks passed
@maticzav maticzav deleted the feat/async-patch branch January 14, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants