Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-commit, flake, black configs #42

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jeffersonkr
Copy link
Contributor

@jeffersonkr jeffersonkr commented May 15, 2022

issue #32

  • added black, ruff config
    • (100 characteres per line was set as default)
  • added pre-commit config
  • run black and ruff on all project files

Copy link
Owner

@matheuscas matheuscas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're missing the pre-commit in test-requirements.

Ps.: Soon, I'll migrate the project to poetry, but for now, let's use what we have.

@matheuscas
Copy link
Owner

Hey @jeffersonkr sorry about answering in a different era. Do you still want to finish it? If so, take a look at the recent changes that I did and I'd recommend using ruff and black instead of flake and isort. Lemme know.

@jeffersonkr
Copy link
Contributor Author

Hi matheus, sure lets do it

@jeffersonkr
Copy link
Contributor Author

hi @matheuscas, could you review the code

Copy link
Owner

@matheuscas matheuscas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffersonkr jeffersonkr closed this Apr 3, 2024
@jeffersonkr jeffersonkr reopened this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants