-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pre-commit, flake, black configs #42
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing the pre-commit
in test-requirements.
Ps.: Soon, I'll migrate the project to poetry, but for now, let's use what we have.
Hey @jeffersonkr sorry about answering in a different era. Do you still want to finish it? If so, take a look at the recent changes that I did and I'd recommend using ruff and black instead of flake and isort. Lemme know. |
Hi matheus, sure lets do it |
This reverts commit 33a0842.
hi @matheuscas, could you review the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
issue #32