Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the design and the logo in documentation #268

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ZahraMirzaiyan
Copy link
Member

No description provided.

@dario-coscia dario-coscia self-assigned this Mar 25, 2024
@dario-coscia dario-coscia added the pr-to-fix Label for PR that needs modification label Mar 25, 2024
@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Mar 28, 2024
@dario-coscia
Copy link
Collaborator

There is one conflict to solve, but for me is mergeable after it

Copy link
Member

@ndem0 ndem0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-coscia it seems something went wrong: actually in this PR you're trying to REMOVE all the files from PINA. Please revert

@ndem0 ndem0 added pr-to-fix Label for PR that needs modification and removed pr-to-review Label for PR that are ready to been reviewed labels Mar 29, 2024
@dario-coscia dario-coscia requested a review from ndem0 March 29, 2024 10:20
@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Mar 29, 2024
@dario-coscia
Copy link
Collaborator

@dario-coscia it seems something went wrong: actually in this PR you're trying to REMOVE all the files from PINA. Please revert

Done, sorry for the inconvinence

@dario-coscia dario-coscia self-requested a review March 29, 2024 10:32
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

# The reST default role (used for this markup: `text`) to use for all documents.
default_role = 'literal'

# Generate the API documentation when building
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed @ZahraMirzaiyan ?

"icon": "fab fa-github",
"type": "fontawesome",
},
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZahraMirzaiyan please remove it for now

@dario-coscia dario-coscia added pr-to-fix Label for PR that needs modification and removed pr-to-review Label for PR that are ready to been reviewed labels Mar 29, 2024
@dario-coscia
Copy link
Collaborator

@ZahraMirzaiyan any updates on this?

@ZahraMirzaiyan
Copy link
Member Author

ZahraMirzaiyan commented May 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-to-fix Label for PR that needs modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants