Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update passing localization object for children rows #845

Merged
merged 1 commit into from May 21, 2024

Conversation

KippWade
Copy link
Contributor

@KippWade KippWade commented May 7, 2024

Related Issue

#830 - Child row of a child row does not show "Are you sure you want to delete this row?"

Description

In local testing, the localization wouldn't always pass the same object to children rows for editing. Thus the deleteText would not exist.
Added localization.editRow and this gave the row the correct information to display the appropriate deleteText

Impacted Areas in Application

When a table is utilizing parent/child and inline row editing, children of children would not display the deleteText.

*

@KippWade KippWade requested a review from oze4 as a code owner May 7, 2024 23:37
@Domino987 Domino987 merged commit 9617d7a into material-table-core:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants