[Internal] Stop using deprecated androidx.core.view.* methods #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pubiqq can you add more context in your descriptions? It helps with the reviews, thanks! |
pubiqq
force-pushed
the
internal/remove-deprecated-core-view
branch
from
7525d2b
to
dac8815
Compare
|
Done. |
pubiqq
force-pushed
the
internal/remove-deprecated-core-view
branch
from
dac8815
to
611792c
Compare
|
I see 2 files added on my end when trying to sync to our internal repo:
These files do exist already under third_party/java_src/android_libs/material_components/lib/java/com/google/android/material/transition Can you take a look? |
pubiqq
force-pushed
the
internal/remove-deprecated-core-view
branch
from
611792c
to
5758dba
Compare
|
Ok, I've removed the changes from the auto-generated classes, but unfortunately I have no way to check if they're generated correctly because I don't have access to your build system, so you'll have to check it yourself. |
pubiqq
force-pushed
the
internal/remove-deprecated-core-view
branch
2 times, most recently
from
605b361
to
5b20c4f
Compare
Open
pubiqq
force-pushed
the
internal/remove-deprecated-core-view
branch
3 times, most recently
from
dd157e8
to
4b07938
Compare
pubiqq
force-pushed
the
internal/remove-deprecated-core-view
branch
from
4b07938
to
47dd802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR replaces deprecated classes and methods from
androidx.core.view.*packages with the recommended ones.Among them:
ViewCompat.LAYOUT_DIRECTION_RTL->View.LAYOUT_DIRECTION_RTLViewCompat.getLayoutDirection(view)->view.getLayoutDirection()ViewCompat.setBackground(view, background)->view.setBackground(background)ViewCompat.setFitsSystemWindows(view, true)->view.setFitsSystemWindows(true)AccessibilityEventCompat.TYPE_WINDOW_CONTENT_CHANGED->AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGEDMarginLayoutParamsCompatclass ->ViewGroup.MarginLayoutParamsclassand so on.