Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] Make datepicker fullscreen #4002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manabu-nakamura
Copy link
Contributor

@raajkumars
Copy link
Contributor

@manabu-nakamura Thanks for the PR. But can you explain why the date picker must be made to occupy fullscreen always? For ex: if the date picker is shown on a large screen tablet, then we would not want it to occupy the entire screen.

@manabu-nakamura
Copy link
Contributor Author

(before) The fullscreen datepicker is not fullscreen (edge-to-edge) in 2 & 3-button navigation mode.
292883762-fb14bee4-06c0-42a2-a631-01a44aee9db3
292883786-44e566ff-8abc-4af0-8eae-2bb354850726
294677855-01ec476d-8bd1-43de-8844-e86f29bfc3bb
(after)
292883815-abec546f-acb7-4197-854e-4dee933174f0
292883825-4905ee67-2fb7-4eac-969c-08734e923c07
294677869-8dda01a4-9d70-4a6b-8565-9e3c558988b6

Copy link
Contributor

@raajkumars raajkumars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants