[BottomSheet] Recycle the TypedArray after usage

material-components · Feb 6, 2024 · f9ac4cf · f9ac4cf
1 parent 8921204
commit f9ac4cf
Showing 1 changed file with 12 additions and 17 deletions.
diff --git a/lib/java/com/google/android/material/bottomsheet/BottomSheetDialog.java b/lib/java/com/google/android/material/bottomsheet/BottomSheetDialog.java
@@ -90,38 +90,33 @@ public class BottomSheetDialog extends AppCompatDialog {
 
   public BottomSheetDialog(@NonNull Context context) {
     this(context, 0);
-
-    edgeToEdgeEnabled =
-        getContext()
-            .getTheme()
-            .obtainStyledAttributes(new int[] {R.attr.enableEdgeToEdge})
-            .getBoolean(0, false);
+    initialize();
   }
 
   public BottomSheetDialog(@NonNull Context context, @StyleRes int theme) {
     super(context, getThemeResId(context, theme));
     // We hide the title bar for any style configuration. Otherwise, there will be a gap
     // above the bottom sheet when it is expanded.
     supportRequestWindowFeature(Window.FEATURE_NO_TITLE);
-
-    edgeToEdgeEnabled =
-        getContext()
-            .getTheme()
-            .obtainStyledAttributes(new int[] {R.attr.enableEdgeToEdge})
-            .getBoolean(0, false);
+    initialize();
   }
 
   protected BottomSheetDialog(
       @NonNull Context context, boolean cancelable, OnCancelListener cancelListener) {
     super(context, cancelable, cancelListener);
     supportRequestWindowFeature(Window.FEATURE_NO_TITLE);
     this.cancelable = cancelable;
+    initialize();
+  }
+
+  private void initialize() {
+    final TypedArray a = getContext()
+        .getTheme()
+        .obtainStyledAttributes(new int[] {R.attr.enableEdgeToEdge});
+
+    edgeToEdgeEnabled = a.getBoolean(0, false);
 
-    edgeToEdgeEnabled =
-        getContext()
-            .getTheme()
-            .obtainStyledAttributes(new int[] {R.attr.enableEdgeToEdge})
-            .getBoolean(0, false);
+    a.recycle();
   }
 
   @Override