fix: Added a check for a hardcoded aria 'role' value in the same element. #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will stop it from "guessing" if an element is a navigation or main element if the element has the aria role of 'navigation' or 'main'. It won't need to guess it if it is specifically outlined to be that.
JMac118
commented
Mar 28, 2024
There was a problem hiding this comment.
When a website has a aria value of 'navigation' or 'main' the extension can still add "guessed" values to the list when it really doesn't need to, which will cause duplicate landmarks in the extension (one actual value, one guessed). This change should stop that.
JMac118
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will stop it from "guessing" if an element is a navigation or main element if the element has the aria role of 'navigation' or 'main'. It won't need to guess it if it is specifically outlined to be that.