Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n-task rspec tests #30258

Closed
wants to merge 3 commits into from
Closed

Add i18n-task rspec tests #30258

wants to merge 3 commits into from

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented May 11, 2024

Notice during a bundle install

# Install default configuration:
cp $(bundle exec i18n-tasks gem-path)/templates/config/i18n-tasks.yml config/
# Add an RSpec for missing and unused keys:
cp $(bundle exec i18n-tasks gem-path)/templates/rspec/i18n_spec.rb spec/
# Or for minitest:
cp $(bundle exec i18n-tasks gem-path)/templates/minitest/i18n_test.rb test/
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details

The task part is already there, and there is the check-i18n.yml Action that does some of this and may be able to be dropped.

@nschonni
Copy link
Contributor Author

Not sure if it would make sense to convert the checks in bundle exec rake repo:check_locales_files as well

@mjankowski
Copy link
Contributor

I would prefer to leave these as-is (CLI task run in CI and locally at discretion) rather than default part of spec suite. They are pretty slow given the size of the translations.

@nschonni nschonni closed this May 13, 2024
@nschonni nschonni deleted the i18n-rspec branch May 13, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants