Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class to mentions to differentiate from other toots #30080

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Colin-Marvin
Copy link

Fix #8424
Appreciate any constructive criticism, this is for a university project, and is also my first time attempting to contribute to open source as a whole.

@shleeable
Copy link
Contributor

Thank you for your PR.

@renchap
Copy link
Sponsor Member

renchap commented Apr 26, 2024

Your change does not only add a class for mentions, but it also changes how they are styled. Is this expected?

@Colin-Marvin
Copy link
Author

No, it's merely a placeholder with the goal to get feedback on how to actually connect it to custom CSS. I was attempting to do something along the lines of #8399, but it seems the admin side of this is different than user.

@ClearlyClaire
Copy link
Contributor

Hi! Thank you for your contribution.

Unfortunately, I don't understand the use case of the linked issue: I don't understand if they want the mention themselves to have a specific class, or the post container itself. I also don't understand if they want this for every mention or for mentions to the author. I think, with the context that they have given, that what they want is not mention links to have a specific class, but post containers for mention notifications to have such a class.

We could ask for clarification, but given how old the issue is, I'm not sure we will have a reply.

No, it's merely a placeholder with the goal to get feedback on how to actually connect it to custom CSS. I was attempting to do something along the lines of #8399, but it seems the admin side of this is different than user.

Mastodon has currently no facility for user-set CSS (beyond admins being able to set custom CSS for the whole site), and I'm not sure trying to do this is a good idea, I think that use case is best served by browser extensions dedicated to this. Furthermore, I think the original issue is not about that, but just about having some CSS class to select on. Therefore I would leave out any actual CSS change from this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a class to mentions to differentiate them from all other toots
4 participants