Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Style/SignalException cop #30064

Merged
merged 1 commit into from Apr 29, 2024
+2 −10
Merged

Disable Style/SignalException cop #30064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions .rubocop_todo.yml
View file
Open in desktop
Expand Up @@ -205,14 +205,6 @@ Style/SafeNavigation:
Exclude:
- 'app/models/concerns/account/finder_concern.rb'

# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: only_raise, only_fail, semantic
Style/SignalException:
Exclude:
- 'lib/devise/strategies/two_factor_ldap_authenticatable.rb'
- 'lib/devise/strategies/two_factor_pam_authenticatable.rb'

# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Mode.
Style/StringConcatenation:
Expand Down
2 changes: 1 addition & 1 deletion lib/devise/strategies/two_factor_ldap_authenticatable.rb
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ def authenticate!
if resource && !resource.otp_required_for_login?
success!(resource)
else
fail(:invalid)
fail(:invalid) # rubocop:disable Style/SignalException -- method is from Warden::Strategies::Base
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/devise/strategies/two_factor_pam_authenticatable.rb
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ def authenticate!
if resource && !resource.otp_required_for_login?
success!(resource)
else
fail(:invalid)
fail(:invalid) # rubocop:disable Style/SignalException -- method is from Warden::Strategies::Base
end
end

Expand Down