Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration.statuses.max_characters to initial_state from instance api on frontend #27850

Closed
wants to merge 4 commits into from

Conversation

sinoru
Copy link
Sponsor Contributor

@sinoru sinoru commented Nov 14, 2023

Using instance api's configuration.statuses.max_characters on frontend to evaluate character limit.

This will fixes some tiny parts of #12265.

@sinoru sinoru changed the title Using max_characters from instance api on frontend. Using configuration.statuses.max_characters from instance api on frontend. Nov 14, 2023
@sinoru sinoru changed the title Using configuration.statuses.max_characters from instance api on frontend. Using configuration.statuses.max_characters from instance api on frontend Nov 14, 2023
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is the best way to go as the server configuration is not fetched immediately.

See also #27629 which has another approach to passing the character limit down.

@sinoru
Copy link
Sponsor Contributor Author

sinoru commented Nov 14, 2023

I am not sure this is the best way to go as the server configuration is not fetched immediately.

See also #27629 which has another approach to passing the character limit down.

@ClearlyClaire Ooops, I didn't know about #27629 PR and initialState things...

How do you think about #27833?
If it is okay-ish, I can close this PR, and make #27833 suitable for or base on (If @shleeable agrees) #27629.

@sinoru
Copy link
Sponsor Contributor Author

sinoru commented Nov 18, 2023

Changes to use initial_state and matching to InstanceSerializer (api/*/instance) for future-proof to add additional values to use on frontend.

@sinoru sinoru changed the title Using configuration.statuses.max_characters from instance api on frontend Add configuration.statuses.max_characters to initial_state from instance api on frontend Nov 18, 2023
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@mjankowski
Copy link
Contributor

Closing because I think #28928 does effectively same thing.

If I'm missing something here, please rebase, re-open, explain, etc...

@mjankowski mjankowski closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants