New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds initial tf-use-cases post #24

Open

Gowiem wants to merge 5 commits into master from feature/add-usecases-post

Member

Gowiem commented May 10, 2024

Info

GDoc for this post: https://docs.google.com/document/d/1vnooxNLvudSql-7QVxYw3OdfIsYUX1hu-bp8n4RtdY4/edit#heading=h.lyamvksa4j4u
This has already been reviewed, but give me another set of eyes on formatting please!


          feat: adds initial tf-use-cases post

78c3e78

Gowiem requested review from kevcube, gberenice and a team

May 10, 2024 19:31

Gowiem self-assigned this

netlify bot commented May 10, 2024 •

edited

✅ Deploy Preview for masterpoint ready!

Name	Link
🔨 Latest commit	`85068e7`
🔍 Latest deploy log	https://app.netlify.com/sites/masterpoint/deploys/66438a3a6754ef0008e5859b
😎 Deploy Preview	https://deploy-preview-24--masterpoint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 35 Accessibility: 86 Best Practices: 83 SEO: 83 PWA: 70 View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.


          chore: small formatting fixes

4c40edf

gberenice reviewed

View reviewed changes

Member

gberenice left a comment

A couple of small suggestions; overall looks good! 🚀

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved

content/updates/terraform-use-cases.md Outdated


		Here’s an excerpt of a `team.yaml` file that describes a hypothetical DevOps team:

		`devops_team:`

Member

gberenice May 13, 2024

Is this intended? Or should it be a part of the yaml code?

Member Author

Gowiem May 13, 2024

Good catch! Fixing in separate thread!

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved

Gowiem commented

View reviewed changes

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved


          fix: @gberenice 's grammar fixes + good catches

f9228e0

Co-authored-by: Veronika Gnilitska <30597968+gberenice@users.noreply.github.com>

Gowiem requested a review from gberenice

May 13, 2024 14:04

gberenice reviewed

View reviewed changes

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved


          fix: indentation

d5c5e9f

Co-authored-by: Veronika Gnilitska <30597968+gberenice@users.noreply.github.com>

Gowiem requested review from gberenice and oycyc

May 13, 2024 14:54

gberenice previously approved these changes

View reviewed changes

Member

gberenice left a comment

oycyc reviewed

View reviewed changes

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved

oycyc reviewed

View reviewed changes

content/updates/terraform-use-cases.md Outdated Show resolved Hide resolved


          chore: adds @oycyc 's suggestions 👍

85068e7

Co-authored-by: yangci <yangciouou@gmail.com>

Gowiem dismissed gberenice’s stale review via

85068e7

May 14, 2024 15:58

Gowiem requested review from oycyc and gberenice

May 14, 2024 15:58

oycyc approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment