Fix issues with main menu music script #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Fixed dynamic_background=dustbowl to play music (Although after testing it, it is a bit weird hearing music and the soundscapes of background01. Up to taste, maybe worth having a "no music" option?) -Fixed dynamic_background=preload setting `dynamic_background_level` to `echo dynamic_background=itemtest` -Fixed typo causing Taps to not play during Soldier holiday.
doesn't clean whitespace. can a linux user come fix this please
mastercoms
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should've noticed these issues before, but I only double checked the PR after it was merged.
-Changed comment in comfig.cfg to actually say what it does
-Fixed dynamic_background=dustbowl to play music (Although after testing it, it is a bit weird hearing music and the soundscapes of background01. Up to taste, maybe worth having a "no music" option?)
-Fixed dynamic_background=preload setting
dynamic_background_leveltoecho dynamic_background=itemtest-Fixed typo causing Taps to not play during Soldier holiday
-Added .nut files to the cleanItems function in dev/common.sh to reduce filesize. I have 0 experience with this so I just added these to the pre-existing cleaning functions. It DOES NOT clean whitespace! also there's some places in the file that need a bit of whitespace, so a naive script won't work.