Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor configure.ac changes for eventual 3.0 release #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sedwards
Copy link
Contributor

  • Add message to end of configure script for next steps
  • Switch default build from GTK+ 2.0 to GTK+ 3.0
  • Mark GTK+ 3.0 support as no longer experimental
  • Add option to test GTK 4.0 building as experimental
  • Add a error message if all GTK libraries are disabled without passing --disable-gtkport
  • Add a note that --disable-gtkport is experimental

The real main change here is switching the default from GTK+ 2.x to GTK+ 3.x line and marking the disable-gtkport option as experimental because it is currently broken anyway

- Switch default build from GTK+ 2.0 to GTK+ 3.0
- Mark GTK+ 3.0 support as no longer experimental
- Add option to test GTK 4.0 building as experimental
- Add a error message if all GTK libraries are disabled without passing --disable-gtkport
- Add a note that --disable-gtkport is experimental
@wdlkmpx
Copy link
Collaborator

wdlkmpx commented Jul 25, 2023

Gtk3 is still experimental, there's an ugly hack to set a reasonable size for the log window, I applied something that works in my distro, but overall the sizes can slightly increase or decrease each time gftp is started. Stuff is broken. Overall the GtkPaned stuff looks really bad

I'll test this later, but I feel there's too much hope, gtk4 support will probably happen in 2040 and without my seal of approval

@sedwards
Copy link
Contributor Author

I am not convinced gtk4.0 will ever happen, I just thought it would be good to have the configure option to try what we can. After thinking about, I agree that since the GtkTreeview stuff is not quite complete for the transfers, maybe it ought not be the default yet, maybe we should just leave this PR as a draft and then come back to it once you think Gtk3 is ready.

On a related note, I am going to close out my other PR about the XPM->PNG migration as if we are going to keep gtk2 around for a long time, we need to come up with a nice clean way to support all versions and image types so I will revisit that later.

@wdlkmpx
Copy link
Collaborator

wdlkmpx commented Aug 7, 2023

Let keep this open for a while until the gtk3 ui is fixed, but I'm not sure what to do with the broken stuff. Gtk is good for simple dialogs and very primitive apps, anything else becomes a major PITA (and requires QT or something) as you port it to the next version that is more primitive and uglier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants