Test for #9655

[Dreamsorcerer]

#9655

[Dreamsorcerer]

Well, this looks roughly like what I'd expect for a test to reproduce the issue, but I can't even figure out how to stop it showing no_results in the list view...

[fzaninotto]

If you're not able to build a unit test demonstrating your problem, perhaps you could fork the simple example codesandbox and tweak it until it show the problem? Or does it only show in unit tests?

[Dreamsorcerer]

Or does it only show in unit tests?

Yes, I mentioned it's only causing a test failure. It seems the dialog doesn't get closed in jest-dom, whereas it does get closed in Firefox when using it as a normal user.

[fzaninotto]

In that case, we'll wait until you can provide a unit test that fails because of the issue you mentioned.

[Dreamsorcerer]

Any tips on how to make it display some results? I'm copying from other, similar tests in this project, so can't see why it's not working here if it's working in those other tests..

[slax57]

Any tips on how to make it display some results? I'm copying from other, similar tests in this project, so can't see why it's not working here if it's working in those other tests..

Tests results are visible in the logs:
https://github.com/marmelab/react-admin/actions/runs/7863886168/job/21455003047?pr=9659#step:5:3073

If you cloned the project locally and already ran make install successfully, you should be able to run the tests and iterate on it by running make test-unit-watch.

[Dreamsorcerer]

Any tips on how to make it display some results? I'm copying from other, similar tests in this project, so can't see why it's not working here if it's working in those other tests..

Tests results are visible in the logs: https://github.com/marmelab/react-admin/actions/runs/7863886168/job/21455003047?pr=9659#step:5:3073

Sorry, I don't think I was clear. I meant, if you look at the test output it renders ra.navigation.no_results. I don't understand why the list view has no results when I've added a dataProvider with getOne, getList and getMany. It looks similar to the other tests in this project...

[slax57]

Thanks for the additional explanations.

I believe the list is empty because you are providing a ListContextProvider with no data. If you expect the list to call getList, you should use the useListController via either List or ListBase.

[fzaninotto]

May I suggest you test your changes locally before pushing them? We get notified of each of your tries.

[Dreamsorcerer]

I wasn't able to run the tests locally using the instructions. Currently, the record data seems to be failing to update from the bulk update button entirely. Not sure why this isn't working...

[fzaninotto]

Sorry, I closed this PR by mistake.

I have created a test for the BulkUpdateButton in #9826, and it seems to work fine. Unless you can tweak this test to make it fail, we'll consider that the problem is on your side.