Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrollbar not appear on scrollable tabs #5713

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

AnkitaGupta111
Copy link
Contributor

@AnkitaGupta111 AnkitaGupta111 commented Dec 23, 2020

Closes #1689

@AnkitaGupta111 AnkitaGupta111 changed the title fix scrollbar not appear on scrollable tabs Fix scrollbar not appear on scrollable tabs Dec 23, 2020
@fzaninotto
Copy link
Member

I don't see what your PR changes or fixes. Can you elaborate?

@fzaninotto
Copy link
Member

Also, you're setting a div width to 0 while it should obviously not have zero width. Can you explain why you're doing that?

@AnkitaGupta111
Copy link
Contributor Author

#1689 (comment)
i just tried using this solution and now tabs are scrollable

@fzaninotto
Copy link
Member

Blindly adding code without understanding how it works won't make a good fix. Please elaborate on the reason why we need this counter-intuitive null width.

@fzaninotto fzaninotto changed the base branch from master to 3.x April 12, 2022 16:44
@fzaninotto fzaninotto added the v3 label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lot of tabs shows scrollbar and crashes the application
2 participants