Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sanitizing __ types #5243

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Commits on Sep 11, 2020

  1. Remove sanitizing __ types

    When using graphql, we rely on `__typename` for identifying the correct types in a `union` type.
    
    imagine i have the following interface
    
    ```
    interface Animal {
        id: ID!
    }
    
    type Crawler implements Animal {
        legs: Int
    }
    
    type Swimmer implements Animal {
        fins: Int
    }
    ```
    
    we would return a type of the form `union SomeAnimal = Crawler & Swimmer` where we rely on `__typename` to correctly display some information on the dashboard.
    
    With this proposal I ask to not filter out `__` fields.
    maximgeerinck committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    113c993 View commit details
    Browse the repository at this point in the history