New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scroll buttons to tabs when they go beyond the available space #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienMattiussi
added
WIP
Work In Progress
RFR
Ready For Review
and removed
WIP
Work In Progress
labels
Mar 16, 2020
djhi
requested changes
Mar 17, 2020
JulienMattiussi
force-pushed
the
too-much-tabs
branch
from
March 24, 2020 13:22
1dc38d6
to
4c4e94f
Compare
JulienMattiussi
force-pushed
the
too-much-tabs
branch
from
April 1, 2020 14:30
4c4e94f
to
8558ada
Compare
Sadly, tests are failing :( |
JulienMattiussi
force-pushed
the
too-much-tabs
branch
from
June 18, 2020 16:26
8558ada
to
110792d
Compare
Luwangel
suggested changes
Jul 31, 2020
Luwangel
suggested changes
Aug 3, 2020
JulienMattiussi
force-pushed
the
too-much-tabs
branch
from
August 3, 2020 14:39
e3357c9
to
d737c16
Compare
Luwangel
approved these changes
Aug 3, 2020
fzaninotto
added a commit
that referenced
this pull request
Aug 11, 2020
This was referenced Aug 11, 2020
Reverted in #5132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1689
Issue
A lot of tabs in TabbedForm or TabbedShow make all page wide and scrollable instead of using scrolling tab buttons.
Solution
Enable scrollable tabs by default, and add a prop to keep possibility to disable it
Screenshots