This repository has been archived by the owner on May 4, 2019. It is now read-only.
[RFR][Do not merge] Migrate to react-admin #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fzaninotto
commented
Nov 9, 2017
•
fzaninotto
commented
- Make app compile
- Make it look good
fzaninotto
changed the title
|
Switching to RFR. To be merged only when react-admin 2.0 is released. |
djhi
reviewed
Nov 29, 2017
| userLogin({ username, password }, location.state ? location.state.nextPathname : '/'); | ||
| } | ||
| login = auth => | ||
| this.props.userLogin( |
There was a problem hiding this comment.
Less readable imho. I prefer when props are deconstructed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.