Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: astro-font - optimize fonts & prevent CLS #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rishi-raj-jain
Copy link

No description provided.

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for accessible-astro ready!

Name Link
🔨 Latest commit 98966bd
🔍 Latest deploy log https://app.netlify.com/sites/accessible-astro/deploys/662a86d6c2c252000849c430
😎 Deploy Preview https://deploy-preview-91--accessible-astro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rishi-raj-jain rishi-raj-jain marked this pull request as draft January 13, 2024 17:47
@markteekman
Copy link
Owner

Hey @rishi-raj-jain, I see this is still on draft, let me know when you're ready for me to take a look at it. Can you also elaborate your changes and maybe explaining the advantages of your package?

Thanks!

@rishi-raj-jain
Copy link
Author

Hey @markteekman,

the changes would basically involve using CSS variables to use personalised fallback font generated to optimise CLS & Layout Shifts of the page caused due to fonts.

explaining the advantages of your package?

More into how astro-font is built: https://www.launchfa.st/blog/building-astro-font

Basically, it optimally load web fonts with zero layout shift, thanks to the underlying CSS size-adjust property used.

@markteekman
Copy link
Owner

Sounds good @rishi-raj-jain, thanks for explaining! I'll look into the PR soon 😄

@markteekman markteekman self-requested a review January 26, 2024 11:29
@markteekman markteekman self-assigned this Jan 26, 2024
@rishi-raj-jain
Copy link
Author

@markteekman

Give me a day or two, and I'll get this to completion...

@rishi-raj-jain rishi-raj-jain marked this pull request as ready for review April 25, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants