remove trailing forward slashes from exclusions #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exclusions are not set correctly and as a result the contents of node_modules will not get ignored, causing a huge amount of file watchers to be created.
This is because chokidar, which is used by livereload, appends string exclusions (other possible exclusions are globstrings and regular expressions) with
"/**". Since our exclusions are.git/andnode_modules/this results in the following exclusions in chokidar:This pull request removes the trailing slashes so that the matching works in chokidar and the contents of the node_modules folder gets ignored.
As a side note the reason .git was ignored even with this problem present is because chokidar ignores .git by default.
fixes #128