Fix tailwind cli path error #840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I have just tested this and I am on windows and can clarify it worked too! thank you so much, can't believe I didn't notice it myself Would be worth getting this merged @marklawlor as its a breaking issue for people with blank spaces in file paths |
|
Glad I could help! |
|
@benrbowers This has nothing to do with the issue you tagged. It fixes #813. I will rename the pull request to make it clear. |
|
This is a major issue that needs to be rectified. Which version of this package implements this change. This issue with not wrapping the command in a string on windows, has broken the turborepo-t3 starter template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the cli error by passing the cli path as a string.
I had the same issue as #813 and executed the tw cli directly. I noticed that the blank spaces were not escaped in the cli path which the error gave me. The referenced issue also shows an error with a path which has a blank space.
Only tested this on mac so unix works, but can't test windows.
This should close #813.