Improve performance of reference definition list parsing #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #996
Looks like the reference definitions cannot interrupted by any of the elements if I read the spec correctly.
None of the tests fail.
By removing the redundant termination logic checks the speed of parsing long list of reference definitions improves dramatically.
~2.5x on the benchmark included in this repo, but in our example where we have 1000 definitions it's almost 20x!
benchmark before
benchmark after