Feat: recaptcha added #227

akshitarora921 · 2021-10-03T18:02:59Z

Self-Review Checklist

PR title is clear with proper spelling and grammar
PR description contains a bulleted list of changes contained in the PR
PR links to relevant issues, with keywords to auto-close any issues fully resolved upon merge
All automated checks passed
Any variables introduced are named clearly and explicitly
One variable added :
File .env.example NEXT_PUBLIC_SITE_KEY

Steps to generate Site Key:

Login to the google reCaptcha website
Click in Plus button(Create) in the second bar.
Fill in the details
Select this configuration
In the domain add the site domain for which you want reCaptcha to work.
eg: https://www.margaritahumanitarian.org/ or localhost
Multiple owners can be added also.
Click on accept and submit
Site code will be generated now. Copy that code and paste it into the env file.

closes #162

vercel · 2021-10-03T18:03:03Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/margaritahumanitarian/helpafamily/7hhfbYi2rYxEc2tjUR5ZFHJjHpuw
✅ Preview: https://helpafamily-git-fork-akshitarora92-1f1867-margaritahumanitarian.vercel.app

akshitarora921 · 2021-10-04T07:15:12Z

Need to do 2 things:

add site code from margaritahumanitarian account.(Currently I am using my account)
fetch site-code from .env file. (I tried but its giving error line 129 components/MainDonationForm.js)

components/MainDonationForm.js

.env.example

akshitarora921 · 2021-10-05T14:13:13Z

Any update on this? @audreyfeldroy

LowLifeArcade · 2021-10-06T21:09:35Z

@akshitarora921 so did we figure out what we're doing with the keys here?

LowLifeArcade · 2021-10-06T21:10:26Z

.env.example

@@ -2,7 +2,7 @@ STRIPE_SECRET_KEY = "sk_test_51JJ3vNLOlCyqSHKrp2vu93c9YzrXxDq7otphDYZqQTE10eZ0Gs
 CANCEL_URL = "https://helpafamily.margaritahumanitarian.org/"
 SUCCESS_URL = "https://helpafamily.margaritahumanitarian.org/thank-you"
 NEXT_PUBLIC_GMAPS_JS_API_KEY = "<your Google Maps JavaScript API Key here>"
-
+NEXT_PUBLIC_SITE_KEY=6LcjyaccAAAAAAjE2z6vBhs2tOdhC-t0F2OCMj7z


@akshitarora921 So let's get this part figured out and we can get this PR in! :)

Hey @akshitarora921. So I think what would help a lot is for you to explain what you're doing with these keys.

Where are they from

What are they doing

What we need to do

I've looked into it and it might be better next time for us to get your PR through if you outline what we need to do as a follow up to your work. A list of todos. Here's an example for todos for us:

Go to recaptha website and generate keys for production

Use sitekey in code (go into detail)

Use secret key in server env (go into detail)

This would help a lot.

LowLifeArcade · 2021-10-06T21:13:44Z

@akshitarora921 if you would rebase your codebase (fetch upstream or go to your forked repo and click fetch) as well so everything is up to date. 🙏

merge main repo

LowLifeArcade · 2021-10-06T21:56:21Z

.env.example

@@ -2,7 +2,7 @@ STRIPE_SECRET_KEY = "sk_test_51JJ3vNLOlCyqSHKrp2vu93c9YzrXxDq7otphDYZqQTE10eZ0Gs
 CANCEL_URL = "https://helpafamily.margaritahumanitarian.org/"
 SUCCESS_URL = "https://helpafamily.margaritahumanitarian.org/thank-you"
 NEXT_PUBLIC_GMAPS_JS_API_KEY = "<your Google Maps JavaScript API Key here>"
-
+NEXT_PUBLIC_SITE_KEY=6LcjyaccAAAAAAjE2z6vBhs2tOdhC-t0F2OCMj7z


Hey @akshitarora921. So I think what would help a lot is for you to explain what you're doing with these keys.

Where are they from

What are they doing

What we need to do

I've looked into it and it might be better next time for us to get your PR through if you outline what we need to do as a follow up to your work. A list of todos. Here's an example for todos for us:

Go to recaptha website and generate keys for production

Use sitekey in code (go into detail)

Use secret key in server env (go into detail)

This would help a lot.

LowLifeArcade · 2021-10-06T21:58:06Z

Need to do 2 things:

add site code from margaritahumanitarian account.(Currently I am using my account)

fetch site-code from .env file. (I tried but its giving error line 129 components/MainDonationForm.js)

I see you did this which is nice. Maybe a little more detail to help us get this PR through. I’ve updated your PR description with a Self-Review Checklist and some to-dos.

I also noticed that one of the checks failed. Please take a look and let me know if you need help.

akshitarora921 · 2021-10-07T14:13:30Z

@LowLifeArcade updated PR description.

LowLifeArcade · 2021-10-07T16:52:37Z

@LowLifeArcade updated PR description.

Thank you @akshitarora921. Don't worry, we'll get this PR through soon. The test failure might be due to recaptcha doing its job. I don't know this for sure and will have to look into it.

akshitarora921 · 2021-10-07T18:46:59Z

@LowLifeArcade yes the form does not submit until the captcha is not submitted that's why the tests are failing.

LowLifeArcade · 2021-10-11T22:38:33Z

@LowLifeArcade yes the form does not submit until the captcha is not submitted that's why the tests are failing.

It seems the sitekey is causing an issue too.

LowLifeArcade · 2021-10-23T01:15:39Z

@akshitarora921 I've been meaning to talk with you about this PR. Will you please make a test or modify the test running on the MainDonationForm component? That needs to pass in your PR before we can do anything else.

akshitarora921 · 2021-10-23T07:36:58Z

@LowLifeArcade I am learning how to write tests, will update the PR as soon as possible.

LowLifeArcade · 2021-12-20T21:43:21Z

@akshitarora921 I think it's time we get this one through :) It's really just a matter of making it pass the test file in the repo.

recaptcha added

6f3d5ac

vercel bot deployed to Preview October 3, 2021 18:03 View deployment

ozer550 suggested changes Oct 4, 2021

View reviewed changes

components/MainDonationForm.js Outdated Show resolved Hide resolved

.env.example Outdated Show resolved Hide resolved

env fixed and updated .env.example

87393e9

vercel bot deployed to Preview October 4, 2021 14:34 View deployment

LowLifeArcade added the hacktoberfest-accepted label Oct 5, 2021

LowLifeArcade requested changes Oct 6, 2021

View reviewed changes

akshitarora921 added 2 commits October 7, 2021 03:01

Merge pull request #1 from margaritahumanitarian/main

3ee5069

merge main repo

Merge branch 'main' into Feature/reCaptcha

46db9d8

vercel bot deployed to Preview October 6, 2021 21:34 View deployment

LowLifeArcade requested changes Oct 6, 2021

View reviewed changes

add steps to create site key in .env.example

795cad2

vercel bot deployed to Preview October 7, 2021 14:22 View deployment

akshitarora921 added 2 commits October 23, 2021 13:09

Merge branch 'margaritahumanitarian:main' into main

66bade0

Merge branch 'main' into Feature/reCaptcha

4d508e0

vercel bot deployed to Preview October 23, 2021 09:39 View deployment

LowLifeArcade added help wanted Extra attention is needed high priority Help urgently needed and your PR will be reviewed extra quickly labels Oct 28, 2021

akshitarora921 marked this pull request as draft November 4, 2021 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: recaptcha added #227

Feat: recaptcha added #227

akshitarora921 commented Oct 3, 2021 •

edited

vercel bot commented Oct 3, 2021 •

edited

akshitarora921 commented Oct 4, 2021 •

edited

akshitarora921 commented Oct 5, 2021 •

edited

LowLifeArcade commented Oct 6, 2021

LowLifeArcade Oct 6, 2021

akshitarora921 Oct 6, 2021

akshitarora921 Oct 6, 2021

LowLifeArcade Oct 6, 2021 •

edited

LowLifeArcade commented Oct 6, 2021

LowLifeArcade Oct 6, 2021 •

edited

LowLifeArcade commented Oct 6, 2021 •

edited

akshitarora921 commented Oct 7, 2021

LowLifeArcade commented Oct 7, 2021

akshitarora921 commented Oct 7, 2021

LowLifeArcade commented Oct 11, 2021

LowLifeArcade commented Oct 23, 2021

akshitarora921 commented Oct 23, 2021

LowLifeArcade commented Dec 20, 2021

Feat: recaptcha added #227

Are you sure you want to change the base?

Feat: recaptcha added #227

Conversation

akshitarora921 commented Oct 3, 2021 • edited

Self-Review Checklist

vercel bot commented Oct 3, 2021 • edited

akshitarora921 commented Oct 4, 2021 • edited

akshitarora921 commented Oct 5, 2021 • edited

LowLifeArcade commented Oct 6, 2021

LowLifeArcade Oct 6, 2021

Choose a reason for hiding this comment

akshitarora921 Oct 6, 2021

Choose a reason for hiding this comment

akshitarora921 Oct 6, 2021

Choose a reason for hiding this comment

LowLifeArcade Oct 6, 2021 • edited

Choose a reason for hiding this comment

LowLifeArcade commented Oct 6, 2021

LowLifeArcade Oct 6, 2021 • edited

Choose a reason for hiding this comment

LowLifeArcade commented Oct 6, 2021 • edited

akshitarora921 commented Oct 7, 2021

LowLifeArcade commented Oct 7, 2021

akshitarora921 commented Oct 7, 2021

LowLifeArcade commented Oct 11, 2021

LowLifeArcade commented Oct 23, 2021

akshitarora921 commented Oct 23, 2021

LowLifeArcade commented Dec 20, 2021

akshitarora921 commented Oct 3, 2021 •

edited

vercel bot commented Oct 3, 2021 •

edited

akshitarora921 commented Oct 4, 2021 •

edited

akshitarora921 commented Oct 5, 2021 •

edited

LowLifeArcade Oct 6, 2021 •

edited

LowLifeArcade Oct 6, 2021 •

edited

LowLifeArcade commented Oct 6, 2021 •

edited