Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onpress event for Button #601

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented May 3, 2024

Changes the onclick event handler of Button to onpress because it will now work with:

  • 🖱️ Click events
  • ⌨️ Enter events when focused
  • 👆 Touch events

@marc2332 marc2332 added enhancement 🔥 New feature or request breaking labels May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 73.21%. Comparing base (885959c) to head (f817601).
Report is 4 commits behind head on main.

Current head f817601 differs from pull request most recent head 5da4ad5

Please upload reports for the commit 5da4ad5 to get more accurate results.

Files Patch % Lines
crates/components/src/button.rs 79.06% 9 Missing ⚠️
crates/components/src/hooks/use_form.rs 0.00% 1 Missing ⚠️
crates/components/src/switch.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   73.29%   73.21%   -0.08%     
==========================================
  Files         192      192              
  Lines       19177    19116      -61     
==========================================
- Hits        14055    13995      -60     
+ Misses       5122     5121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review May 15, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant