handle null chars in dxorg.cpp:getValueFromSysFsFile() #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QString truncates strings after the first occurance of a null character. If a sysfs file contains null characters in the middle of the contents, the output of getValueFromSysFsFile() is incomplete. This replaces all occurances of null chars in the QByteArray returned from QFile::readAll() before converting it to a QString. This also fixes segfaults on startup when incomplete pp_od_clk_voltage tables are being parsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QString truncates strings after the first null character. If a sysfs file contains null chars in the middle of its contents, the output of getValueFromSysFsFile() is incomplete.
This fix replaces all occurrences of null chars in the QByteArray returned from QFile::readAll() before converting it to a QString.
This fixes segfaults on startup when incomplete pp_od_clk_voltage tables are being parsed (#279).