[#1140] adds warning when the target has no target properties #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- warning that no actual target properties are targeted/written to should be given when compiling
zyberzebra
commented
May 7, 2024
processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java
Show resolved
Hide resolved
filiphr
reviewed
May 18, 2024
There was a problem hiding this comment.
Thanks for your work on this @zyberzebra. I've left some comments.
processor/src/main/java/org/mapstruct/ap/internal/util/Message.java
Outdated
Show resolved
Hide resolved
processor/src/main/java/org/mapstruct/ap/internal/util/Message.java
Outdated
Show resolved
Hide resolved
processor/src/test/java/org/mapstruct/ap/test/bugs/_1140/AirplaneWithNoAccessors.java
Outdated
Show resolved
Hide resolved
processor/src/test/java/org/mapstruct/ap/test/bugs/_1140/JarMapperTest.java
Outdated
Show resolved
Hide resolved
|
@filiphr I'm not 100% what the correct workflow is. Should I request reviews when I'm ready or not? |
|
The workflow is me trying to get time and going through all the emails and updated PRs 😀. I usually go through PRs that have been updated as well |
Thanks for the clarification ! I just scrolled through some other pull request here and saw that some request reviews and because it's my first time working open source I was unsure. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference: #1140
TODO: