#3133 Redundant null check in generated code when adding parameters #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyberzebra
force-pushed
the
#3133-fix-Redundant-null-check-in-generated-code
branch
from
67239e1
to
7016d48
Compare
- verify redundant null checks in mappings are avoided - targets mapper methods that involve update mappings and ensures that null checks are not applied redundantly if already covered - tests for multiple scenarios
zyberzebra
force-pushed
the
#3133-fix-Redundant-null-check-in-generated-code
branch
from
0b95442
to
464cc8b
Compare
zyberzebra
commented
Apr 29, 2024
There was a problem hiding this comment.
I used the code formatter in IntelliJ: etc/mapstruct.xml
Imported here:
There was a problem hiding this comment.
When you are formatting it is best to only format the changed lines and also when committing it is best to only stage changes that are not formatting changes.
I'll clean up the not needed formatting changes now, that's not a problem
There was a problem hiding this comment.
Aaaah... makes sense! Thanks for clearing that up 😁
zyberzebra
force-pushed
the
#3133-fix-Redundant-null-check-in-generated-code
branch
from
9bc9826
to
82f7835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for: #3133