Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2892 #2904

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feature/2892 #2904

wants to merge 14 commits into from

Conversation

Zegveld
Copy link
Contributor

@Zegveld Zegveld commented Jun 21, 2022

  • Merge main branch and fix moved imports. (Periodically needed)
  • Write in the README.md how to use the testutils in other modules.
  • Stop passing the configuration interface along and have the static retrieval method cache the action.
  • Make what the methods on the configuration interface are used for more obvious with javadoc and renaming.
  • Move to another repository. (Finishing action)

closes #2892

@filiphr
Copy link
Member

filiphr commented Jun 22, 2022

This would ideally be in a new project under a new organization. It doesn't fit well with what MapStruct is doing.

Anyways, the move to a dedicated non publishable module is a good step to separate it more from MapStruct.

What I would suggest in order to avoid a lot of changes is to limit certain things for now.

  • IssueKey should not be moved
  • WithJakartaInject, WithJavaxInject, WithJavaxJaxb, WithJoda, WithJoda should not be moved. They are all meta annotations for WithTestDependency.
  • For easier review, I would also suggest if possible to do everything in the current packages and add new things that are need. e.g. the ProjectTestConfiguration
  • Seems like checkstyle should be an optional dependency as well

I haven't done a thorough analysis of this yet though

@Zegveld
Copy link
Contributor Author

Zegveld commented Jun 30, 2022

The diff should be a lot better now. The reverted changes were all import updates, because of moved items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test-utils a separate module
2 participants