Adding mapping registry convenience fields to the SSSOM data model #264
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (@anitacaron, me, @udp) are currently trying to build a nice REST API for SSSOM. There are certain fields that are not intended to add any "metadata" to a specific mapping, but are used by the API model which in turns is using the SSSOM object model (including auto-generated data classes etc).
We originally tried to hack everything into the
otherfield, but this has various problems, including that you potentially overwrite existing content which may be important metadata.The alternative is to create 1 field (mapping_registry_other) which is more flexible, allowing us to add arbitrary extensions from the side of the mapping_registry (in case we need other such parameters).