Remove uri slot from Entity REF #244
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think about adding a test here. |
|
See also here: #241 (comment) |
matentzn
commented
Dec 3, 2022
|
@hrshdhgd can you help me with the PR again when you get a minute? I cant get https://github.com/mapping-commons/sssom/pull/244/files#diff-5607ecbac7dd39511f45b6ae9cd7bf6140c32d1c61674e594c09468256c7e17fR20 to work.. |
matentzn
commented
Dec 5, 2022
|
Found the solution. |
|
THANK YOU @hrshdhgd, much appreciated. Once this is merged, is it your understanding the the jsonld export will work in general? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
trying to model the Entity reference correctly
Fails:
https://github.com/mapping-commons/sssom/pull/244/files#diff-
5607ecbac7dd39511f45b6ae9cd7bf6140c32d1c61674e594c09468256c7e17fR20