Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybind11 [WIP] #276

Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open

Pybind11 [WIP] #276

wants to merge 77 commits into from

Conversation

artemp
Copy link
Member

@artemp artemp commented Apr 29, 2024

Port to pybind11 and remove dependency on boost::python.

FYI @mathisloge

@artemp artemp self-assigned this Apr 29, 2024
@mathisloge
Copy link
Collaborator

Oh cool @artemp !
You could take a look at scikit-core. They have an example here: https://github.com/pybind/scikit_build_example

In my experience it's quite easier to develop with, since you will have a normal cmake setup or the python packaging process.

@artemp
Copy link
Member Author

artemp commented Apr 29, 2024

You could take a look at scikit-core. They have an example here: https://github.com/pybind/scikit_build_example

In my experience it's quite easier to develop with, since you will have a normal cmake setup or the python packaging process.

@mathisloge I will definitely take a look, thanks! As a first iteration I'd like to ensure setuptools are updated and are working. But I'm aware pybind11 integrates well with CMake, which would be the next step.

@artemp
Copy link
Member Author

artemp commented May 29, 2024

pytest test/python_tests 🟢
==== 390 passed in 29.22s ==

Remaining TODO: Fix handling of uninitialised placement finder(s) in text rendering in mapnik core + add missing properties to symbolisers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants