Updates to configure pycairo if available #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @davenquinn - definitely something that fell through the cracks in the split. Don't have the mindspace right now to review this method meaningfully but I will say that I wonder if we can rethink pycairo support such that it is not a compile time thing. |
|
Yeah, it might be reasonable to just remove the |
…into setup-updates * 'master' of https://github.com/davenquinn/python-mapnik: Fix thread-local variables to use cross-platform Boost version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mapnik core does not check to see if python cairo is importable as part of its
prebuild. Thus, the includes for pycairo (and the define
HAVE_PYCAIRO) are notpart of the
mapnik-config --cflagsoutput. (In the Mapnik scons script,HAS_PYCAIRO=Falseis set. This seems reasonable in general, if we are trying to separate python concerns
from the core software. But that means that there is no way to use pycairo from the python bindings if we want it. This adds a check to the setup to see if we can drag in pycairo.