-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile and installation instructions #4153
base: v3.0.x
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## v3.0.x #4153 +/- ##
==========================================
- Coverage 68.96% 67.02% -1.94%
==========================================
Files 446 446
Lines 22984 22324 -660
==========================================
- Hits 15851 14963 -888
- Misses 7133 7361 +228
Continue to review full report at Codecov.
|
I have no idea why the code coverage would change for this PR. It does not touch the source or tests. |
Many thanks for the Dockerfile. Did you test to include the python-bindings in the Dockerimage? I have tried, but did not suceed so far. |
Here's a (tested) Dockerfile that adds python-bindings to mapnik3 docker from jawg. |
Based on https://github.com/jawg/docker-mapnik3 and jawg/docker-mapnik3#8. Usage of Apache licensed software (the image build instructions in this case) should be fine if the Apache License is mentioned explicitly (it is in this PR).
This PR should fix #3704.
Travis integration is still needed: https://docs.travis-ci.com/user/docker/#building-a-docker-image-from-a-dockerfile
The Python and Node bindings could have their own Docker image which also compile those bindings into a derived image.
Each 'main' branch of the project should have it's own image, in particular each release.