Reduce backward memory to ~half #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reuse y_act_ and dy_act_ - use inplace calculations in `forward_cpu` and `backward_cpu`
- make sure dy_act doesn't have memory overlaping - reflect the inplace operations in the doc and comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the grad and input tensors in the backward pass instead of creating new ones.
Mainly reuse
y_actforxhatanddy_actfordy.Ensure every function support in-place operation. (Elu is modified accordingly)
Ensure the tensors allow in-place operation (
dy_acthas to be contiguous)Needs more testing. However, there are no unit tests.