Fix crs input for reproject #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
commented
Feb 26, 2018
| @@ -129,7 +129,7 @@ def _tile_worker(tile): | |||
| reproject( | |||
| rasterio.band(src, 1), out, | |||
| dst_transform=toaffine, | |||
| dst_crs="init='epsg:3857'", | |||
| dst_crs='epsg:3857', | |||
There was a problem hiding this comment.
This is the best way to do it for web mercator. If the previous worked, it would have only been by accident, as Rasterio was only expecting +init=epsg:3857 (no quotes inside the string).
|
It looks like there hasn't been a Travis build in a year until this one and tests are failing due to changes in dependencies. |
|
This built fine ~ 3 months ago: https://travis-ci.org/mapbox/rio-rgbify/builds/316721443?utm_source=github_status&utm_medium=notification -- I'll look into the test changes |
|
Please, merge that. The project is no more usable as is. |
|
I guess this issue is now fixed and this PR could be closed. https://github.com/mapbox/rio-rgbify/blob/master/rio_rgbify/mbtiler.py#L141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a reported issue.