platform-dependent name of the node-webkit's executable #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Travis CI test of this change fails for some obscure reason. As an additional test I pushed a commit to the source branch of TryGhost/node-sqlite3#252, using a tarball of the source branch of #36 as a source of node-pre-gyp. The resulting Travis CI log (line 1700) shows that node-pre-gyp now calls |
HTTPS remote_uri is required since 57c9a77.
springmeyer
pushed a commit
that referenced
this pull request
Feb 13, 2014
platform-dependent name of the node-webkit's executable
springmeyer
pushed a commit
to TryGhost/node-sqlite3
that referenced
this pull request
Apr 9, 2014
A pull request (mapbox/node-pre-gyp#36) is opened to land a partial fix for node-pre-gyp's validation process. This commit uses a source branch of that pull request. After this commit, node-pre-gyp's validator is expected to launch `nw` instead of `node-webkit` on Travis CI's Linux. A former ENOENT error is expected to be replaced by a node-webkit's error when the engine realises it's given a node-sqlite3 module's JavaScript instead of some HTML5 application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to run
node-webkiton Linux fails inevitably (see, for example, this Travis CI log, line 1700).This pull request provides a set of platform-dependent names.